Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update api to v1 17 #159

Merged
merged 4 commits into from
Mar 1, 2021
Merged

Update api to v1 17 #159

merged 4 commits into from
Mar 1, 2021

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented Jan 25, 2021

  • Update protobuf to v1.17
  • Fix tests to work with v2/v3

We should make separate PR with V2 deprecation because Envoy since 1.17 doesn't support V2 configuration and requires flag to enable.

Lukasz Dziedziak added 4 commits January 25, 2021 15:57
Signed-off-by: Lukasz Dziedziak <lukasz.dziedziak@allegro.pl>
Signed-off-by: Lukasz Dziedziak <lukasz.dziedziak@allegro.pl>
Signed-off-by: Lukasz Dziedziak <lukasz.dziedziak@allegro.pl>
Signed-off-by: Lukasz Dziedziak <lukasz.dziedziak@allegro.pl>
@lukidzi lukidzi force-pushed the update-api-to-v1_17 branch from 41fbc3a to bad3397 Compare January 25, 2021 14:57
@lukidzi lukidzi requested a review from slonka January 26, 2021 09:00
@sschepens
Copy link
Contributor

@slonka @snowp @jakubdyszkiewicz can someone have a look at this and get a release out please?

@slonka
Copy link
Member

slonka commented Feb 27, 2021

I will review it on Monday at the latest.

@slonka slonka merged commit a85a9b1 into main Mar 1, 2021
@slonka slonka deleted the update-api-to-v1_17 branch March 1, 2021 09:05
@slonka
Copy link
Member

slonka commented Mar 1, 2021

@sschepens released v0.1.28 🎊

@sschepens
Copy link
Contributor

@slonka thanks!!

slonka pushed a commit that referenced this pull request May 20, 2021
* Update protobuf to envoy 1.17

Signed-off-by: Lukasz Dziedziak <lukasz.dziedziak@allegro.pl>

* Use v2 version

Signed-off-by: Lukasz Dziedziak <lukasz.dziedziak@allegro.pl>

* Support V2/V3 in Envoy - remove V2 in separate PR

Signed-off-by: Lukasz Dziedziak <lukasz.dziedziak@allegro.pl>

* UDPA download - split directory create/copy

Signed-off-by: Lukasz Dziedziak <lukasz.dziedziak@allegro.pl>
Signed-off-by: slonka <slonka@users.noreply.github.com>
Ferdudas97 added a commit that referenced this pull request Sep 9, 2022
* delta xds

Signed-off-by: Sebastian Schepens <sebastian.schepens@mercadolibre.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>

* fixes

Signed-off-by: Sebastian Schepens <sebastian.schepens@mercadolibre.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>

* method naming

Signed-off-by: Sebastian Schepens <sebastian.schepens@mercadolibre.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>

* Building version of non-breaking changes

Signed-off-by: slonka <slonka@users.noreply.github.com>

* Get integration tests passing

Signed-off-by: slonka <slonka@users.noreply.github.com>

* Add delta tests back

Signed-off-by: slonka <slonka@users.noreply.github.com>

* Rewrite V3DiscoveryServerAdsDeltaResourcesIT to have a 2 second poll delay to account for potential delays in writing to the wire (we don't want that to happen)

Signed-off-by: slonka <slonka@users.noreply.github.com>

* Add comment to trigger PR build

Signed-off-by: slonka <slonka@users.noreply.github.com>

* Get V3DiscoveryServerXdsDeltaResourcesIT passing

Signed-off-by: slonka <slonka@users.noreply.github.com>

* Update protobuf to envoy 1.16.0 (#155)

* Update protobuf to envoy 1.16.0

Signed-off-by: Lukasz Jedryczka <lukasz.jedryczka@allegro.pl>

* Fixing test by setting -boostrap-version 2 flag

Signed-off-by: Lukasz Jedryczka <lukasz.jedryczka@allegro.pl>

* Update protobuf to envoy 1.16.0

Signed-off-by: Lukasz Jedryczka <lukasz.jedryczka@allegro.pl>

* Information about update envoy image version in README.md

Signed-off-by: wookieJ <lukaszjedryczka.biuro@gmail.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>

* release: prepare release v0.1.25

Signed-off-by: slonka <slonka@users.noreply.github.com>

* release: prepare for next development iteration

Signed-off-by: slonka <slonka@users.noreply.github.com>

* release: prepare release v0.1.26

Signed-off-by: slonka <slonka@users.noreply.github.com>

* release: prepare for next development iteration

Signed-off-by: slonka <slonka@users.noreply.github.com>

* Bump nexus release plugin timeout to 20 minutes (#156)

Signed-off-by: slonka <slonka@users.noreply.github.com>

* release: prepare release v0.1.27

Signed-off-by: slonka <slonka@users.noreply.github.com>

* release: prepare for next development iteration

Signed-off-by: slonka <slonka@users.noreply.github.com>

* ci: fixes javadoc and jacoco plugin issues (#158)

Signed-off-by: karthik <listaction@gmail.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>

* Update api to v1 17 (#159)

* Update protobuf to envoy 1.17

Signed-off-by: Lukasz Dziedziak <lukasz.dziedziak@allegro.pl>

* Use v2 version

Signed-off-by: Lukasz Dziedziak <lukasz.dziedziak@allegro.pl>

* Support V2/V3 in Envoy - remove V2 in separate PR

Signed-off-by: Lukasz Dziedziak <lukasz.dziedziak@allegro.pl>

* UDPA download - split directory create/copy

Signed-off-by: Lukasz Dziedziak <lukasz.dziedziak@allegro.pl>
Signed-off-by: slonka <slonka@users.noreply.github.com>

* Fix references to main branch after rename (#160)

Signed-off-by: slonka <slonka@users.noreply.github.com>

* release: prepare release v0.1.28

Signed-off-by: slonka <slonka@users.noreply.github.com>

* release: prepare for next development iteration

Signed-off-by: slonka <slonka@users.noreply.github.com>

* Change version to 0.1.29-delta-xds-slonka-SNAPSHOT

Signed-off-by: slonka <slonka@users.noreply.github.com>

* Revert ads configs to main

Signed-off-by: slonka <slonka@users.noreply.github.com>

* Hash bytes array not string

Signed-off-by: slonka <slonka@users.noreply.github.com>

* Remove unused import

Signed-off-by: slonka <slonka@users.noreply.github.com>

* Revert snapshot name

Signed-off-by: slonka <slonka@users.noreply.github.com>

* Remove respondDeltaTracked since it's not used anywhere

Signed-off-by: slonka <slonka@users.noreply.github.com>

* Delta xds non breaking hash bytes refactor (#181)

* refactor delta xds

Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl>

* refactor setDeltaWatch and remove code duplication

Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl>

* resolve TODO in SnapshotTest

Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl>

* Change version to 0.1.29-delta-xds-slonka-SNAPSHOT

Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl>

* DEPLOY_BRANCH added for snapshot deploy

Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl>

* changes after merge master with new envoy api

Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl>

* make CacheStatusInfoAggregator public

Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl>

* make GroupCacheStatusInfo and MutableStatusInfo public

Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl>

* refactor SimpleCache

Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl>

* create resources map only once

Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl>

* build snapshot with improved performance

Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl>

* refactor creating snapshot resources due to performance improvements

Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl>

* create hash version from string

Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl>

* remove custom snapshot version and deploy branch env

Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl>

* fix test after merge

Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl>

* fix V3DeltaDiscoveryServerCallbacks description

Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl>

Signed-off-by: Sebastian Schepens <sebastian.schepens@mercadolibre.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
Signed-off-by: wookieJ <lukaszjedryczka.biuro@gmail.com>
Signed-off-by: karthik <listaction@gmail.com>
Signed-off-by: Lukasz Dziedziak <lukasz.dziedziak@allegro.pl>
Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl>
Co-authored-by: Sebastian Schepens <sebastian.schepens@mercadolibre.com>
Co-authored-by: mgajda <mgajda@hubspot.com>
Co-authored-by: Łukasz Jędryczka <34069409+wookieJ@users.noreply.github.com>
Co-authored-by: envoy-bot <envoy-bot@users.noreply.github.com>
Co-authored-by: Karthik Ram <listaction@gmail.com>
Co-authored-by: Łukasz Dziedziak <lukasz.dziedziak@allegro.pl>
Co-authored-by: Radek Chrzanowski <ferdudas97@gmail.com>
Co-authored-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants