bazel/unpacker: Fix empty placeholder (#2390)

Signed-off-by: Ryan Northey <ryan@synca.io>
envoyproxy · Nov 4, 2024 · 227cf35 · 227cf35
1 parent 55782b2
commit 227cf35
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 3 deletions.
diff --git a/bazel/tarball/BUILD b/bazel/tarball/BUILD
@@ -1 +1,4 @@
-exports_files(["unpack.sh"])
+exports_files([
+    "PLACEHOLDER.TXT",
+    "unpack.sh",
+])
diff --git a/bazel/tarball/macros.bzl b/bazel/tarball/macros.bzl
@@ -5,6 +5,15 @@ def unpacker(
         zstd = None,
         visibility = ["//visibility:public"],
 ):
+
+    native.genrule(
+        name = "placeholder",
+        outs = ["PLACEHOLDER.TXT"],
+        cmd = """
+        touch $@
+        """,
+    )
+
     native.filegroup(
         name = "true",
         srcs = [],
@@ -15,9 +24,14 @@ def unpacker(
         srcs = [],
     )
 
+    native.filegroup(
+        name = "empty",
+        srcs = [":placeholder"],
+    )
+
     native.label_flag(
         name = "target",
-        build_setting_default = ":false",
+        build_setting_default = ":empty",
         visibility = ["//visibility:public"],
     )
 

diff --git a/bazel/tarball/unpack.sh b/bazel/tarball/unpack.sh
@@ -7,7 +7,7 @@ TARGET="${TARGET:-}"
 OVERWRITE="${OVERWRITE:-}"
 EXTRACT_PATH="$1"
 
-if [[ -z "$TARGET" ]]; then
+if [[ -z "$TARGET" || "$TARGET" == "PLACEHOLDER.TXT" ]]; then
     echo "TARGET must be provided using a bazel flag." >&2
     exit 1
 fi