grpc graceful shutdown #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
April 22, 2020 14:58
Signed-off-by: Jyoti Mahapatra <jmahapatra@lyft.com>
Signed-off-by: Jyoti Mahapatra <jmahapatra@lyft.com>
Signed-off-by: Jyoti Mahapatra <jmahapatra@lyft.com>
Signed-off-by: Jyoti Mahapatra <jmahapatra@lyft.com>
jyotimahapatra
requested review from
eapolinario,
LisaLudique,
jessicayuen and
lita
added 2 commits
April 22, 2020 23:02
Signed-off-by: Jyoti Mahapatra <jmahapatra@lyft.com>
lita
reviewed
Apr 23, 2020
| ) | ||
|
|
||
| func TestXdsClientGetsIncrementalResponsesFromUpstreamServer(t *testing.T) { | ||
| dir, err := os.Getwd() |
There was a problem hiding this comment.
Is this guaranteed to be here in CI jobs? Should there be an environment variable but default to this if it is not set?
There was a problem hiding this comment.
yeah..the CI jobs are set up to correctly set the folder https://github.com/envoyproxy/xds-relay/blob/master/.github/workflows/integration-tests.yml#L40
They run locally too without any changes.
jessicayuen
reviewed
Apr 23, 2020
jessicayuen
reviewed
Apr 23, 2020
added 8 commits
April 23, 2020 15:27
Signed-off-by: Jyoti Mahapatra <jmahapatra@lyft.com>
Signed-off-by: Jyoti Mahapatra <jmahapatra@lyft.com>
Signed-off-by: Jyoti Mahapatra <jmahapatra@lyft.com>
Signed-off-by: Jyoti Mahapatra <jmahapatra@lyft.com>
Signed-off-by: Jyoti Mahapatra <jmahapatra@lyft.com>
Signed-off-by: Jyoti Mahapatra <jmahapatra@lyft.com>
jessicayuen
approved these changes
Apr 24, 2020
jessicayuen
pushed a commit
to jessicayuen/xds-relay
that referenced
this pull request
Apr 24, 2020
Signed-off-by: Jyoti Mahapatra <jmahapatra@lyft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jyoti Mahapatra jmahapatra@lyft.com