Add isomorphic-unfetch package #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enzoferey
reviewed
Feb 16, 2023
Comment on lines
+13
to
+15
| rollupOptions: { | ||
| external: ["isomorphic-unfetch"], | ||
| }, |
There was a problem hiding this comment.
Awesome 👌🏻
However we also need for a wider compatibiliy:
Suggested change
| rollupOptions: { | |
| external: ["isomorphic-unfetch"], | |
| }, | |
| rollupOptions: { | |
| external: ["isomorphic-unfetch"], | |
| output: { | |
| globals: { | |
| "isomorphic-unfetch": "fetch", | |
| }, | |
| }, | |
| }, |
There was a problem hiding this comment.
Actually, we are going to build it for now. It's not clear to me the best way to add it as an external dependency at the moment.
|
@matextrem as this is urgent and I can't modify your branch, opened #13. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has the following changes:
isomorphic-unfetchto support both Browser and Node environments given the fact nativefetchAPI is only available in browsers and Node versions >= 18.