Make private properties more private and harder to use

enzymejs · Aug 20, 2017 · bf3aebd · bf3aebd
1 parent c15dd47
commit bf3aebd
Show file tree

Hide file tree

Showing 5 changed files with 204 additions and 124 deletions.
diff --git a/packages/enzyme-test-suite/test/ReactWrapper-spec.jsx b/packages/enzyme-test-suite/test/ReactWrapper-spec.jsx
@@ -18,7 +18,7 @@ import {
   render,
   ReactWrapper,
 } from 'enzyme';
-import { ITERATOR_SYMBOL } from 'enzyme/build/Utils';
+import { ITERATOR_SYMBOL, sym } from 'enzyme/build/Utils';
 import { REACT013, REACT014, REACT16, is } from './_helpers/version';
 
 describeWithDOM('mount', () => {
@@ -1037,6 +1037,7 @@ describeWithDOM('mount', () => {
       expect(setInvalidProps).to.throw(TypeError, similarException.message);
     });
 
+
     itIf(!REACT16, 'should call the callback when setProps has completed', () => {
       class Foo extends React.Component {
         render() {
@@ -1050,7 +1051,7 @@ describeWithDOM('mount', () => {
       const wrapper = mount(<Foo id="foo" />);
       expect(wrapper.find('.foo').length).to.equal(1);
 
-      wrapper.renderer.batchedUpdates(() => {
+      wrapper[sym('__renderer__')].batchedUpdates(() => {
         wrapper.setProps({ id: 'bar', foo: 'bla' }, () => {
           expect(wrapper.find('.bar').length).to.equal(1);
         });

diff --git a/packages/enzyme-test-suite/test/ShallowWrapper-spec.jsx b/packages/enzyme-test-suite/test/ShallowWrapper-spec.jsx
@@ -7,7 +7,7 @@ import sinon from 'sinon';
 import { createClass } from './_helpers/react-compat';
 import { shallow, render, ShallowWrapper } from 'enzyme';
 import { describeIf, itIf, itWithData, generateEmptyRenderData } from './_helpers';
-import { ITERATOR_SYMBOL, withSetStateAllowed } from 'enzyme/build/Utils';
+import { ITERATOR_SYMBOL, withSetStateAllowed, sym } from 'enzyme/build/Utils';
 import { REACT013, REACT014, REACT16, is } from './_helpers/version';
 
 // The shallow renderer in react 16 does not yet support batched updates. When it does,
@@ -4300,14 +4300,14 @@ describe('shallow', () => {
     it('works with a name', () => {
       const wrapper = shallow(<div />);
       wrapper.single('foo', (node) => {
-        expect(node).to.equal(wrapper.node);
+        expect(node).to.equal(wrapper[sym('__node__')]);
       });
     });
 
     it('works without a name', () => {
       const wrapper = shallow(<div />);
       wrapper.single((node) => {
-        expect(node).to.equal(wrapper.node);
+        expect(node).to.equal(wrapper[sym('__node__')]);
       });
     });
   });