Fix componentDidUpdate no longer receives prevContext on React v16 #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We will also want to make this on |
|
I'll work on this after #1133 is merged. |
lelandrichardson
force-pushed
the
fix-prev-context-arg-of-cdu
branch
2 times, most recently
from
9b2107a
to
9cb6ddb
Compare
lelandrichardson
force-pushed
the
fix-prev-context-arg-of-cdu
branch
from
9cb6ddb
to
a08df67
Compare
lelandrichardson
approved these changes
Sep 26, 2017
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix facebook/react#8631.
Currently, a test is failing because of #1133.
This PR depends on #1133 so I should apply this patch to the changes of #1133 when the PR is merged.