Fix finding forwardRef itself #1684
Conversation
| @@ -3,6 +3,11 @@ import PropTypes from 'prop-types'; | |||
|
|
|||
| /* eslint react/forbid-prop-types: 0 */ | |||
|
|
|||
| // TODO: use react-is? | |||
| const specialType = PropTypes.shape({ | |||
| if (typeOf(selector) === ForwardRef) { | ||
| // re-build the predicate based on what is wrapped by forwardRef | ||
| // rather than the forwardRef itself | ||
| return buildPredicate(selector.render().props); |
There was a problem hiding this comment.
I don't think this is the right way to do this but maybe i'm misunderstanding. We should copy waht react-test-renderer does and this code should go in the react-16-adapter
There was a problem hiding this comment.
Actually I'm not sure either. Maybe the root cause of this is that enzyme is not generating a corresponding element for forwardRef and we shouldn't defer searching to the next level here. I'll look into react-test-renderer.
There was a problem hiding this comment.
Yeah the selector module is used for all adapters, so the node type should be opaque in this module.
|
@jquense are you able to pull this PR into yours, such that we don't have to have stacked PRs? |
|
I'll update my PR. I think someone actually already PR'd My PR with the correct fix |
|
(I'll leave this open and sync the two of them myself when the first one's ready to merge) |
This PR is built on top of @jquense 's #1592
It fixes when the
wrapper.findmethod cannot find the forwardRef itself. The reason this is happening is thatReact.forwardRefreturns a type that is unknown to enzyme. The return type looks like this:What we really want to search is the thing wrapped inside of
forwardRef, so one way to do this is to call therendermethod and use the return element to re-build a predicate based on that.