running tests with karma #421
Conversation
nfcampos
force-pushed
the
karma
branch
3 times, most recently
from
3e0b7f3
to
c42d0a0
Compare
|
this is ready to merge now I believe 😀 |
| before_script: | ||
| - "sh install-relevant-react.sh" | ||
| - if [ $KARMA == 1 ]; then export CHROME_BIN=chromium-browser; fi | ||
| - if [ $KARMA == 1 ]; then export DISPLAY=:99.0; fi |
There was a problem hiding this comment.
can all three of these commands be combined into one line, if they're related?
There was a problem hiding this comment.
good point, I've combined them
nfcampos
force-pushed
the
karma
branch
2 times, most recently
from
3ec1838
to
cc386f6
Compare
|
3 tests fail when ran on Firefox 45.0 and react 15.1.0 with karma because of this firefox bug facebook/react#6896 it'll be fixed in a future version of react (or firefox) so I don't think there's anything for us to do here other than be aware of it. |
nfcampos
force-pushed
the
karma
branch
2 times, most recently
from
1fc2967
to
ad37536
Compare
|
oops, accidentally closed this, will reopen tomorrow |
|
@nfcampos what's the status on this? |
|
I'll rebase and after that it should be ready to go |
nfcampos
force-pushed
the
karma
branch
3 times, most recently
from
7747c83
to
d9fbe3e
Compare
|
@aweary do you want to take a look at this before it gets out of date again? :) |
nfcampos
force-pushed
the
karma
branch
2 times, most recently
from
27d488e
to
4672e04
Compare
nfcampos
force-pushed
the
karma
branch
2 times, most recently
from
5d06c6a
to
dee5cba
Compare
|
I've rebased this on the current master, does someone want to review this? |
|
|
||
| var VERSION = React.version; | ||
|
|
||
| module.exports = { |
There was a problem hiding this comment.
why is this file changing from ES6 exports to node exports?
There was a problem hiding this comment.
because I need to import it in the karma conf file and I don't want to transpile that
makes sense?
the other option is to require('babel-register') at the beginning of the karma conf file. would that be better?
There was a problem hiding this comment.
I'd prefer npm run build before the karma tests, so that the tests are always running on the build output.
There was a problem hiding this comment.
hmm ok, makes sense. so i guess the test:karma command in package.json should run build before? or we should do that manually when testing with karma?
There was a problem hiding this comment.
hmm, actually that's pretty inconvenient, because the test files themselves import the source files from src, not from build, what do you suggest for that?
There was a problem hiding this comment.
hm, that's a good point. since the mocha tests use babel-register, let's just use that here too.
| ], | ||
|
|
||
| preprocessors: { | ||
| 'test/*.jsx': ['webpack', 'sourcemap'], |
There was a problem hiding this comment.
.js might need preprocessing too - we use babel for every file, and .jsx is only for files that contain JSX
There was a problem hiding this comment.
good point, will change
There was a problem hiding this comment.
I've changed this
nfcampos
force-pushed
the
karma
branch
2 times, most recently
from
00621f9
to
ed1d057
Compare
|
does anyone else want to review this? |
nfcampos
force-pushed
the
karma
branch
2 times, most recently
from
4f51d06
to
d7f1b58
Compare
- rewrote src/version.js in ES5 to be able to use it in karma.conf.js - conditionally add webpack.IgnorePlugin based on React version installed, mirrorring react-compat.js
|
LGTM |
where this is at:
2 are failingfixed now (were failing because the tests were assuming the body was empty)only running in chrome for nowchrome and firefoxtodo