Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failOnError false #48

Merged
merged 1 commit into from
Jul 4, 2023
Merged

failOnError false #48

merged 1 commit into from
Jul 4, 2023

Conversation

h1alexbel
Copy link
Member

@h1alexbel h1alexbel commented Jul 4, 2023

closes #47


PR-Codex overview

This PR focuses on adding a new dependency and annotation to the codebase.

Detailed summary

  • Added ru.l3r8y.sa-tan dependency to pom.xml.
  • Added @Mutable annotation to Cached class.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@zoeself
Copy link
Collaborator

zoeself commented Jul 4, 2023

@h1alexbel thank you for your Pull Request. I'll assign someone to review it soon.

If this PR solves a todo from the code, please don't forget to remove it.

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (01048b5) 94.96% compared to head (4862f20) 94.96%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #48   +/-   ##
=========================================
  Coverage     94.96%   94.96%           
  Complexity       84       84           
=========================================
  Files            11       11           
  Lines           159      159           
  Branches          3        3           
=========================================
  Hits            151      151           
  Misses            8        8           
Impacted Files Coverage Δ
src/main/java/io/github/eocqrs/eokson/Cached.java 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zoeself
Copy link
Collaborator

zoeself commented Jul 4, 2023

@h1alexbel please review this Pull Request. Deadline (when it should be merged or closed) is 2023-07-07T15:19:05.967098.

You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough.

Estimation here is 30 minutes, that's how much you will be paid. You will be paid even if this PR gets rejected.

@h1alexbel
Copy link
Member Author

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Jul 4, 2023

@rultor merge

@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 4862f20 into master Jul 4, 2023
@rultor
Copy link
Collaborator

rultor commented Jul 4, 2023

@rultor merge

@h1alexbel Done! FYI, the full log is here (took me 2min)

@zoeself
Copy link
Collaborator

zoeself commented Jul 4, 2023

@h1alexbel thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pom.xml:241: failOnError set to true -->
4 participants