Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo #57

Merged
merged 1 commit into from
Jul 27, 2023
Merged

typo #57

merged 1 commit into from
Jul 27, 2023

Conversation

h1alexbel
Copy link
Member

@h1alexbel h1alexbel commented Jul 27, 2023

PR-Codex overview

This PR focuses on adding the new keyword when initializing Jocument in the README.md file.

Detailed summary

  • Added the new keyword when initializing Jocument in the README.md file.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@zoeself
Copy link
Collaborator

zoeself commented Jul 27, 2023

@h1alexbel thank you for your Pull Request. I'll assign someone to review it soon.

If this PR solves a todo from the code, please don't forget to remove it.

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (839b9c8) 95.42% compared to head (78a3b61) 95.42%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #57   +/-   ##
=========================================
  Coverage     95.42%   95.42%           
  Complexity       88       88           
=========================================
  Files            13       13           
  Lines           175      175           
  Branches          3        3           
=========================================
  Hits            167      167           
  Misses            8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zoeself
Copy link
Collaborator

zoeself commented Jul 27, 2023

@h1alexbel please review this Pull Request. Deadline (when it should be merged or closed) is 2023-07-30T05:49:09.590721.

You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough.

Estimation here is 30 minutes, that's how much you will be paid. You will be paid even if this PR gets rejected.

@h1alexbel
Copy link
Member Author

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Jul 27, 2023

@rultor merge

@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 78a3b61 into master Jul 27, 2023
8 checks passed
@h1alexbel h1alexbel deleted the typo branch July 27, 2023 06:02
@rultor
Copy link
Collaborator

rultor commented Jul 27, 2023

@rultor merge

@h1alexbel Done! FYI, the full log is here (took me 2min)

@zoeself
Copy link
Collaborator

zoeself commented Jul 27, 2023

@h1alexbel thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants