Skip to content

Commit

Permalink
Revert "Linter: remove jsdoc plugin"
Browse files Browse the repository at this point in the history
This reverts commit 89ec49c.
  • Loading branch information
pakaoraki committed Apr 30, 2024
1 parent 84da80b commit 7ef6741
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 3 deletions.
1 change: 1 addition & 0 deletions .eslintrc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,5 @@ rules: #Override some of the upstream rules to match this codebase
curly:
- error
- all
jsdoc/require-jsdoc: off
prefer-template: off
2 changes: 1 addition & 1 deletion .github/workflows/linter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
version: 1.0
- name: Install eslint
run: |
npm install -g eslint@8.57.0
npm install -g eslint@8.57.0 eslint-plugin-jsdoc
- name: Run linter target
run: |
Expand Down
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ translations:
@./update-locale.sh

lint:
eslint -c .eslintrc.yml $(EXTENSION_DIR)
eslint -c .eslintrc.yml --resolve-plugins-relative-to "$(shell npm root -g)" $(EXTENSION_DIR)

lint-fix:
eslint -c .eslintrc.yml --fix $(EXTENSION_DIR)
eslint -c .eslintrc.yml --resolve-plugins-relative-to "$(shell npm root -g)" --fix $(EXTENSION_DIR)
15 changes: 15 additions & 0 deletions lint/eslintrc-gjs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
env:
es2021: true
extends: 'eslint:recommended'
plugins:
- jsdoc
rules:
array-bracket-newline:
- error
Expand Down Expand Up @@ -61,6 +63,16 @@ rules:
- 'CallExpression[callee.object.name=GObject][callee.property.name=registerClass] > ClassExpression:first-child'
# Allow dedenting chained member expressions
MemberExpression: 'off'
jsdoc/check-alignment: error
jsdoc/check-param-names: error
jsdoc/check-tag-names: error
jsdoc/check-types: error
jsdoc/implements-on-classes: error
jsdoc/require-jsdoc: error
jsdoc/require-param: error
jsdoc/require-param-description: error
jsdoc/require-param-name: error
jsdoc/require-param-type: error
key-spacing:
- error
- beforeColon: false
Expand Down Expand Up @@ -231,6 +243,9 @@ rules:
- inside
yield-star-spacing: error
yoda: error
settings:
jsdoc:
mode: typescript
globals:
ARGV: readonly
Debugger: readonly
Expand Down

0 comments on commit 7ef6741

Please sign in to comment.