Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force Eslint version 8.57.0 #327

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Conversation

pakaoraki
Copy link
Collaborator

Eslint 9 seams to need a complete config rewrite: I tried to migrate the config file to version 9, but I'm not very familiar with it.
In the meantime, we can use the last stable version of Eslint 8 to keep process working.

@stuarthayhurst
Copy link
Collaborator

I'm guessing it's not worth using a package lock file for 2 packages? If that's the case, I agree with this, as it keeps things working for now :)

@matdave
Copy link

matdave commented Apr 29, 2024

I work on many node-based projects, and would argue that the lack of a package / package lock file is the exact cause of this issue. Adding one to the repo would help with signalling a unified version to test against and run locally.

@stuarthayhurst
Copy link
Collaborator

I work on many node-based projects, and would argue that the lack of a package / package lock file is the exact cause of this issue. Adding one to the repo would help with signalling a unified version to test against and run locally.

I mean I don't see why we can't supply the files if it's worthwhile, but the issue seemed to be more that we didn't specify a version, not how we specified a version

@pakaoraki
Copy link
Collaborator Author

I'm sorry because I'm not very familiar with workflow and I didn't really think about package lock file. If it's ok, we can maybe merge this as a temporary fix for the current PR and improve this later.

@pakaoraki pakaoraki merged commit 81172a7 into eonpatapon:master Apr 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants