Don't use any polling when idle mode is used #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -428,8 +428,6 @@ class MPDWrapper(mpd.MPDClient): | |||
| self.stop() | |||
|
|
|||
| def last_status(self): | |||
| if time.time() - self._time >= 2: | |||
| self.timer_callback() | |||
There was a problem hiding this comment.
Not sure why we should refresh the properties here
There was a problem hiding this comment.
You're right, it's probably not necessary. I guess I was just afraid of self._status becoming out of date for some reason...
grawity
added a commit
that referenced
this pull request
Dec 30, 2012
Don't use any polling when idle mode is used
grawity
added a commit
that referenced
this pull request
Dec 31, 2012
Keep polling for now, to detect connection loss during idle (issue #35). Maybe a better solution will be found in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.