feature/MTCE-260-Add-ClassPropertyAssignToConstructorPromotionRector (#…

…1482)
eonx-com · Jul 29, 2024 · eafd668 · eafd668
1 parent 6d6eccd
commit eafd668
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 15 deletions.
diff --git a/packages/EasyDoctrine/tests/Fixture/ValueObject/Price.php b/packages/EasyDoctrine/tests/Fixture/ValueObject/Price.php
@@ -7,14 +7,10 @@
 
 final class Price implements Stringable
 {
-    private string $amount;
-
-    private string $currency;
-
-    public function __construct(string $amount, string $currency)
-    {
-        $this->amount = $amount;
-        $this->currency = $currency;
+    public function __construct(
+        private string $amount,
+        private string $currency,
+    ) {
     }
 
     public function __toString(): string

diff --git a/packages/EasyRepository/src/Repository/AbstractPaginatedDoctrineOrmRepository.php b/packages/EasyRepository/src/Repository/AbstractPaginatedDoctrineOrmRepository.php
@@ -12,12 +12,10 @@
 
 abstract class AbstractPaginatedDoctrineOrmRepository extends AbstractDoctrineOrmRepository implements RepoInterface
 {
-    private PaginationInterface $pagination;
-
-    public function __construct(ManagerRegistry $registry, PaginationInterface $pagination)
-    {
-        $this->pagination = $pagination;
-
+    public function __construct(
+        ManagerRegistry $registry,
+        private PaginationInterface $pagination,
+    ) {
         parent::__construct($registry);
     }
 

diff --git a/quality/rector.php b/quality/rector.php
@@ -43,7 +43,10 @@
         'packages/*/vendor/*', // Composer dependencies installed locally for development and testing
 
         // Skip rules
-        ClassPropertyAssignToConstructorPromotionRector::class,
+        ClassPropertyAssignToConstructorPromotionRector::class => [
+            'packages/*/ApiResource/*',
+            'packages/*/Entity/*',
+        ],
         FirstClassCallableRector::class => [
             'packages/EasyBatch/tests/Stub/Kernel/KernelStub.php',
             'packages/EasyBugsnag/tests/Stub/Kernel/KernelStub.php',