Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EasyMonorepo] Added the ext-openswoole platform to composer.json #1346

Conversation

itorgov
Copy link
Contributor

@itorgov itorgov commented Jan 29, 2024

[EasyMonorepo] Added the ext-openswoole platform to composer.json to be able to install dependencies without the extension.

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets

… to be able to install dependencies without the extension.
@itorgov itorgov requested a review from natepage January 29, 2024 22:40
@eonx-space-to-github-reviews
Copy link

natepage
natepage previously approved these changes Mar 11, 2024
Copy link
Member

@natepage natepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @itorgov. Good job! Code review complete.

Secure code in this PR has been written to best practice standards and covers the following as a minimum. Please ticket if coded this way (also tick if not relevant to this code change):

  • Protect from Injection attacks
  • Protect data with proper input validation, and protect against buffer overflows, pointers/shared data
  • Protect with appropriate encryption and cryptography (E.g. Appropriate hashing, symmetric encryption used, ciphers) if applicable
  • Protect against XSS and CSRF
  • Ensure that pages, data access etc, are written with appropriate access control authorisation and authentication requirements
  • Ensure all important errors and business logic cases are handled
  • Ensure forwards and redirects are handled
  • Ensure no sensitive data is exposed and appropriate logging in place as required

See procedure for more details: PROC-010 Secure Coding Practices

@natepage natepage merged commit 36a6549 into master Mar 11, 2024
13 checks passed
@roman-eonx roman-eonx deleted the feature/easy-monorepo-add-ext-openswoole-platform-to-composer-json branch July 8, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants