-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EasyTest] Created InvalidDataMaker #471
Merged
natepage
merged 9 commits into
master
from
feature/PLU-2760-create-invalid-data-generator
Jan 26, 2021
Merged
[EasyTest] Created InvalidDataMaker #471
natepage
merged 9 commits into
master
from
feature/PLU-2760-create-invalid-data-generator
Jan 26, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- created InvalidDataMaker
- phpstan fixes
- phpstan fixes - dependencies fixes
- added coverage ignore annotations
- fixed GH actions
roman-eonx
requested changes
Jan 25, 2021
packages/EasyTest/src/InvalidDataMaker/AbstractInvalidDataMaker.php
Outdated
Show resolved
Hide resolved
packages/EasyTest/src/InvalidDataMaker/AbstractInvalidDataMaker.php
Outdated
Show resolved
Hide resolved
packages/EasyTest/src/InvalidDataMaker/AbstractInvalidDataMaker.php
Outdated
Show resolved
Hide resolved
packages/EasyTest/src/InvalidDataMaker/AbstractInvalidDataMaker.php
Outdated
Show resolved
Hide resolved
- changes according review
- changes according review
roman-eonx
approved these changes
Jan 26, 2021
egor-dev
approved these changes
Jan 26, 2021
natepage
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing a new util class helpful in functional tests of ApiResource validation.
InvalidDataMaker
can be extended in an application to add new yield methods.When custom validation messages are used in an application, a translation file path should be added either by overriding the
InvalidDataMaker::$translations
property or by calling theInvalidDataMaker::addTranslations()
method from asetUp
method.All the yield methods generate an array with the following items:
data
(an array containing invalid data that can be passed to an API endpoint),message
, andpropertyPath
(a translated message and a property path that can be used to assert the violation details in the error response).Usage examples: