Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport: Allow HTTP-RPC with empty response #435

Closed
linh2931 opened this issue Jun 19, 2022 · 0 comments · Fixed by #630
Closed

Backport: Allow HTTP-RPC with empty response #435

linh2931 opened this issue Jun 19, 2022 · 0 comments · Fixed by #630
Assignees
@heifner
Labels
OCI OCI working this issue...
Milestone
Mandel 3.2.0

Comments

@linh2931
Copy link
Member

EOSIO/eos#9633

Current http request handlers always return the json string converted from fc::variant, it is not allowed to make HTTP-RPC with empty response. (At least, it will have "null" in the case of fc::variant())
@heifner heifner added the OCI OCI working this issue... label Jul 9, 2022
@heifner heifner self-assigned this Jul 9, 2022
@heifner heifner moved this to Todo in ENF Engineering Jul 9, 2022
@heifner heifner moved this from Todo to In Progress in ENF Engineering Jul 9, 2022
@heifner heifner modified the milestones: Mandel 3.2.0, Mandel 3.2.0-rc1 Jul 9, 2022
@heifner heifner mentioned this issue Jul 9, 2022
Merged
heifner added a commit that referenced this issue Jul 11, 2022
@heifner
Merge pull request #630 from eosnetworkfoundation/GH-435-http-empty
2769a23 
[3.2] Allow HTTP-RPC with empty response
Repository owner moved this from In Progress to Done in ENF Engineering Jul 11, 2022
@stephenpdeos stephenpdeos modified the milestones: Mandel 3.2.0-rc1, Mandel 3.2.0 Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
OCI OCI working this issue...
Projects
ENF Engineering
Status: Done
Milestone
Mandel 3.2.0
Development

Successfully merging a pull request may close this issue.

[3.2] Allow HTTP-RPC with empty response eosnetworkfoundation/mandel
3 participants
@heifner @stephenpdeos @linh2931