Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: Standardize JSON formatting of action data #466

Closed
linh2931 opened this issue Jun 20, 2022 · 2 comments
Closed

Backport: Standardize JSON formatting of action data #466

linh2931 opened this issue Jun 20, 2022 · 2 comments

Comments

@linh2931
Copy link
Member

linh2931 commented Jun 20, 2022

Those two should go together.

EOSIO/eos#10100

old code doing this:
act.data ------can parse to json object ? if yes "data"=json object and hex_data = "hex string"
if no "data" = "hex string"

new code doing this:
act.data ------can parse to json object ? if yes "data"=json object and hex_data = "hex string"
if no "hex_data" = "hex string"

and extract function also some changes correspondingly.

Also, please see related test PR here:

EOSIO/eos#10405

@heifner
Copy link
Member

heifner commented Jun 24, 2022

This change needs to be done at a major release point and clearly communicated. It affects all clients as it changes the JSON format.

@vladtr vladtr moved this to Todo in ENF Engineering Jul 1, 2022
@arhag arhag modified the milestone: Mandel 3.2.0-rc1 Jul 1, 2022
@arhag arhag added the planning Propose change to milestone in next planning meeting label Jul 1, 2022
@linh2931
Copy link
Member Author

Not saving to data field is a breaking backward compatibility change. It is agreed not do it. #659 is created to track the hex_field change

Repository owner moved this from Todo to Done in ENF Engineering Jul 12, 2022
@arhag arhag closed this as not planned Won't fix, can't repro, duplicate, stale Jul 13, 2022
@stephenpdeos stephenpdeos removed the planning Propose change to milestone in next planning meeting label Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

4 participants