This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Standardize JSON formatting of action data (epe 151) #10100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d be present whether the action.data can be parsed as json object or not. In the old code, "data" always be present, it could be json object or hex string if parsed successfully or failed.
brianjohnson5972
suggested changes
Mar 2, 2021
brianjohnson5972
approved these changes
Mar 8, 2021
Merged
11 tasks
jgiszczak
added a commit
that referenced
this pull request
Jun 3, 2021
test for existence of "data" field when printing action result, introduced by PR #10100
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Start 100100 description ......
EPE 151
old code doing this:
act.data ------can parse to json object ? if yes "data"=json object and hex_data = "hex string"
if no "data" = "hex string"
new code doing this:
act.data ------can parse to json object ? if yes "data"=json object and hex_data = "hex string"
if no "hex_data" = "hex string"
and extract function also some changes correspondingly.
End 10100 description ......
Change Type
Select ONE
Consensus Changes
API Changes
Documentation Additions
old code doing this:
act.data ------can parse to json object ? if yes "data"=json object and hex_data = "hex string"
if no "data" = "hex string"
new code doing this:
act.data ------can parse to json object ? if yes "data"=json object and hex_data = "hex string"
if no "hex_data" = "hex string"
THe new json formatting for act.data is more clear than old code. The meaning of "hex_data" will be hex data and always present. The meaning of "data" will be only for a successfully parsed json object, it can be not present if parse failed.