[3.2] Get future before use to avoid race on set_value get_future #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoonincode
approved these changes
Jun 21, 2022
|
okay to skip in 3.1 backport imo -- only clutched in when neither Linux nor Mac |
I agree. These never exhibited a problem, they were fixed when similar code did exhibit an issue. |
heifner
approved these changes
Jun 21, 2022
arhag
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport EOSIO/eos#9331. GH issue #460.
In the original code,
get_futureandset_valuerun on different threads and can cause a race condition when modifying/accessing the promise object at the same time. Change to callget_futureat the beginning.