[3.2] Fix db modes test #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n before call wait. As the trace information is very limit. detail see epe889, the buildkite fails are very possible wait an already terminated NODEOS_PID
… go, in not, need stop and return the error code.
…turn code) than 127(non exist child return code), so add dealing of $NODEOS_PID
|
db_modes_test can be parallel. afaict it was moved to nonparallel strictly because it worked better that way on the over subscribed mac VMs b1 was running. and afaik we haven't seen any problems with db_modes_test so my preference would be to keep in parallel as designed. |
|
(it's still a lousy test that should be rewritten though 🙂 ) |
spoonincode
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport EOSIO/eos#10237, EOSIO/eos#10333, and (EOSIO/eos#10736: reverted)
Resolve #443 and #449
Issues resolved:
waitreturns 127 ifnodeoswas already killed and this non-zero return code aborted the testing.db_modes_testas non-parallel: reverted)