Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.1 -> main] Fix log trimming of hex_data JSON output. #549

Merged
merged 4 commits into from
Jun 28, 2022

Conversation

heifner
Copy link
Member

@heifner heifner commented Jun 28, 2022

Merge issue of #190 missed trimming the "hex_data" attribute in logged transaction trace data.

Added transaction_trace_success and transaction_trace_failure trace loggers to eosio-launcher to provide additional logging during tests.

Example:

debug 2022-06-25T18:48:07.183 nodeos producer_plugin.cpp:642 operator() ] [TRX_TRACE] Speculative execution is ACCEPTING tx: {"id":"17ad680cbb16e142f0fc4e0b50a0a5be59362098056c969bb5a7ee00e9beee1c","block_num":18,"block_time":"2022-06-25T18:48:07.500","producer_block_id":null,"receipt":{"status":"executed","cpu_usage_us":2721,"net_usage_words":878},"elapsed":5525,"net_usage":7024,"scheduled":false,"action_traces":[{"action_ordinal":1,"creator_action_ordinal":0,"closest_unnotified_ancestor_action_ordinal":0,"receipt":{"receiver":"eosio","act_digest":"9a90c525172f87bbac0a6378610727f0fe1d7ebe908df973923d29a1606f9a57","global_sequence":18,"recv_sequence":18,"auth_sequence":[["eosio",18]],"code_sequence":1,"abi_sequence":0},"receiver":"eosio","act":{"account":"eosio","name":"setcode","authorization":[{"actor":"eosio","permission":"active"}],"code_hash":"1f5c063768890aad54a6b7079606e4b683e37d8fcf270dfacd9df05f5569348c","data":{"account":"eosio","vmtype":0,"vmversion":0,"code":{"size":17777,"trimmed_hex":"0061736d01000000019d011a60000060037f7e7f0060027f7e0060027f7f0060057f7e7e7e7e0060047f7e7e7e0060017f017f60017f0060037f7f7f017f6000"}},"hex_data":{"size":17790,"trimmed_hex":"0000000000ea30550000f18a010061736d01000000019d011a60000060037f7e7f0060027f7e0060027f7f0060057f7e7e7e7e0060047f7e7e7e0060017f017f"}},"context_free":false,"elapsed":2331,"console":"","trx_id":"17ad680cbb16e142f0fc4e0b50a0a5be59362098056c969bb5a7ee00e9beee1c","block_num":18,"block_time":"2022-06-25T18:48:07.500","producer_block_id":null,"account_ram_deltas":[{"account":"eosio","delta":177770}],"except":null,"error_code":null,"return_value_hex_data":""},{"action_ordinal":2,"creator_action_ordinal":0,"closest_unnotified_ancestor_action_ordinal":0,"receipt":{"receiver":"eosio","act_digest":"e7de58a9939c6e694d3235202685f51b7fab8e82b1f9f96a637dafd9be0998a2","global_sequence":19,"recv_sequence":19,"auth_sequence":[["eosio",19]],"code_sequence":1,"abi_sequence":1},"receiver":"eosio","act":{"account":"eosio","name":"setabi","authorization":[{"actor":"eosio","permission":"active"}],"data":{"account":"eosio","abi":{"size":2176,"trimmed_hex":"0e656f73696f3a3a6162692f312e310019086162695f686173680002056f776e6572046e616d6504686173680b636865636b73756d3235360861637469766174"}},"hex_data":{"size":2186,"trimmed_hex":"0000000000ea305580110e656f73696f3a3a6162692f312e310019086162695f686173680002056f776e6572046e616d6504686173680b636865636b73756d32"}},"context_free":false,"elapsed":2951,"console":"","trx_id":"17ad680cbb16e142f0fc4e0b50a0a5be59362098056c969bb5a7ee00e9beee1c","block_num":18,"block_time":"2022-06-25T18:48:07.500","producer_block_id":null,"account_ram_deltas":[{"account":"eosio","delta":308}],"except":null,"error_code":null,"return_value_hex_data":""}],"account_ram_delta":null,"except":null,"error_code":null}

Resolves #538

Merges latest release/3.1.x into main. #539

@heifner heifner requested a review from linh2931 June 28, 2022 01:38
@heifner heifner added the OCI OCI working this issue... label Jun 28, 2022
@heifner heifner merged commit c2eac41 into main Jun 28, 2022
@heifner heifner deleted the GH-538-fix-hex-trim branch June 28, 2022 12:13
@arhag arhag changed the title [3.2] Fix log trimming of hex_data JSON output. [3.1 -> main] Fix log trimming of hex_data JSON output. Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI OCI working this issue...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

transaction trace loggers not trimming all hex data
2 participants