[3.2] Enhancement: Add unique error message for subjective billing in the transaction trace logs #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladtr
changed the title
heifner
suggested changes
Aug 8, 2022
|
Can you update the PR description with example log messages. |
heifner
reviewed
Aug 10, 2022
heifner
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decision was made not to change exception, just a message, in particular:
Functions affected: validate_account_cpu_usage, validate_account_cpu_usage_estimate and checktime()
It is suggested that error messages with the condition of subjective_billed_us > 0 should be amended with following string:
" with a subjective cpu of (${subjective} us)"
for example, in validate_account_cpu_usage message should be updated as following:
Old:
"estimated CPU time (${billed} us) is not less than the maximum billable CPU time for the transaction (${billable} us)"
New:
"estimated CPU time (${billed} us) is not less than the maximum billable CPU time for the transaction (${billable} us) with a subjective cpu of (${subjective} us)"
Provisions has been made to avoid unneeded duplication of messages in a code.