[3.2] grab bag of warning fixes #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoonincode
commented
Aug 3, 2022
unittests/eosio.token_tests.cpp
Outdated
| @@ -177,7 +177,7 @@ BOOST_FIXTURE_TEST_CASE( create_max_decimals, eosio_token_tester ) try { | |||
| share_type amount = 0x8ac7230489e80000L; | |||
| static_assert(sizeof(share_type) <= sizeof(asset), "asset changed so test is no longer valid"); | |||
| static_assert(std::is_trivially_copyable<asset>::value, "asset is not trivially copyable"); | |||
| memcpy(&max, &amount, sizeof(share_type)); // hack in an invalid amount | |||
| memcpy((char*)&max, &amount, sizeof(share_type)); // hack in an invalid amount | |||
There was a problem hiding this comment.
These were copying an object of non-trivial type warnings. Gnarly fix but, well, comment says it's a hack 😉
There was a problem hiding this comment.
I removed this fix for now, so the other clearly correct ones can be fast pathed in
spoonincode
commented
Aug 3, 2022
| @@ -490,7 +490,7 @@ BOOST_AUTO_TEST_CASE(test_deltas_resources_history) { | |||
|
|
|||
| std::multiset<std::string> expected_contract_row_table_names {"abihash", "abihash", "hashobjs", "hashobjs", "hashobjs", "numobjs", "numobjs", "numobjs"}; | |||
|
|
|||
| std::multiset<uint64_t> expected_contract_row_table_primary_keys {6138663577826885632,14605619288908759040, 0, 1 ,2, 0, 1, 2}; | |||
| std::multiset<uint64_t> expected_contract_row_table_primary_keys {6138663577826885632U,14605619288908759040U, 0, 1 ,2, 0, 1, 2}; | |||
There was a problem hiding this comment.
integer constant is so large that it is unsigned
heifner
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of these are to fix
comparison of integer expressions of different signednessby replacingintwithsize_tfor comparison againstvector<>::size()unless otherwise noted