remove gettext/libintl dependency #95
Conversation
gettext is only used for cleos localization support. But, cleos has not had any effort to translate it nor is that effort on any short term roadmap AFAIK. Remove this dependency for now as it's an LGPL dep and causing some grief. When we get back around to localizing cleos we can reevaluate this need; it's possible something like boost::locale would be a better fit.
| @@ -45,7 +45,6 @@ echo "class Eosio < Formula | |||
| option :universal | |||
|
|
|||
| depends_on \"gmp\" | |||
| depends_on \"gettext\" | |||
There was a problem hiding this comment.
What about gettext-devel in.cicd/platforms/centos-7.6-unpinned.dockerfile and .cicd/platforms/centos-7.6.dockerfile.
If .cicd is not going to be maintained it should be removed.
There was a problem hiding this comment.
Yes absolutely -- anything not used or not tested ought to be removed. .cicd & build scripts fall in that bucket now.
I've been reluctant to PR a change to zap all that since there really isn't a replacement for pinned builds outside the build script. But.. the build scripts are no longer tested or getting attention soooo 🤷 😕
There was a problem hiding this comment.
There is some thought that the .cicd will be used by a new cicd system, which is what Matthew Darwin is talking about below. Maybe go ahead and make the those two changes so we have them just in case.
There was a problem hiding this comment.
imo, there is no viable path for .cicd as is: it's outdated, neglected, overcomplicated, interwoven with b1 infra, and of course currently completely untested. The best course of action appears to be to eliminate it and start anew with something else; using the old files as reference if need be.
|
I assume .cicd will come back at some point. |
gettext is only used for cleos localization support. But, cleos has not had any effort to translate it thus far. Remove this unused dependency for now as it's an LGPL dep and may cause some grief depending on future platform support. When we get back around to localizing cleos we can reevaluate this need; it's possible something like boost::locale would be a better fit.
Port of EOSIO/eos#8118 & EOSIO/eos#10326