Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): APP use new SDK component #1050

Merged
merged 5 commits into from
Jan 10, 2024
Merged

Conversation

fangyinc
Copy link
Collaborator

@fangyinc fangyinc commented Jan 9, 2024

Description

  1. Use SDK ChatPromptTemplate in dbgpt/app/scene and base_chat
  2. Format dbgpt/app codes.
  3. Move the http APIs of conversation to dbgpt/serve/conversation
  4. Use StorageConversation in base_chat

How Has This Been Tested?

make test

Snapshots:

Include snapshots for easier review.

Checklist:

  • My code follows the style guidelines of this project
  • I have already rebased the commits and make the commit message conform to the project standard.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

Closes #1045

@github-actions github-actions bot added core Module: core enhancement New feature or request labels Jan 9, 2024
@csunny
Copy link
Collaborator

csunny commented Jan 9, 2024

ChatExcel scene, when refreshed, the error will occur.

IsADirectoryError: [Errno 21] Is a directory: 'xxx/github/eosphoros-ai/DB-GPT/pilot/data/chat_excel/

@fangyinc
Copy link
Collaborator Author

More format
image

image

Copy link
Collaborator

@csunny csunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

Copy link
Collaborator

@Aries-ckt Aries-ckt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@Aries-ckt Aries-ckt merged commit fa8b5b1 into eosphoros-ai:main Jan 10, 2024
4 checks passed
@fangyinc fangyinc deleted the sdk-dev branch January 10, 2024 02:55
Hopshine pushed a commit to Hopshine/DB-GPT that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Module: core enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Error when using VLLM with knowledge base.:NotImplementedError
3 participants