Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change KnowledgeQueryResponse #1202

Merged
merged 2 commits into from
Feb 27, 2024
Merged

change KnowledgeQueryResponse #1202

merged 2 commits into from
Feb 27, 2024

Conversation

0sengseng0
Copy link
Contributor

@0sengseng0 0sengseng0 commented Feb 26, 2024 •
edited
Loading

Description

change KnowledgeQueryResponse #1132

How Has This Been Tested?

Snapshots:

Checklist:

  • My code follows the style guidelines of this project
  • I have already rebased the commits and make the commit message conform to the project standard.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

csunny
csunny previously approved these changes Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@csunny csunny left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+, thanks for your PR.

Aries-ckt
Aries-ckt previously approved these changes Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@Aries-ckt Aries-ckt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fangyinc fangyinc dismissed stale reviews from Aries-ckt and csunny via 1723d40 February 26, 2024 13:50
csunny
csunny approved these changes Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@csunny csunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

Aries-ckt
Aries-ckt approved these changes Feb 27, 2024
View reviewed changes
Copy link
Collaborator

@Aries-ckt Aries-ckt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@Aries-ckt Aries-ckt merged commit 08fcb4f into eosphoros-ai:main Feb 27, 2024
4 checks passed
csunny pushed a commit to oushu1zhangxiangxuan1/DB-GPT that referenced this pull request Mar 1, 2024
@0sengseng0 @fangyinc @csunny
change KnowledgeQueryResponse (eosphoros-ai#1202)
058e3ab 
Co-authored-by: Fangyin Cheng <staneyffer@gmail.com>
Hopshine pushed a commit to Hopshine/DB-GPT that referenced this pull request Sep 10, 2024
@0sengseng0 @fangyinc @Hopshine
change KnowledgeQueryResponse (eosphoros-ai#1202)
1894996 
Co-authored-by: Fangyin Cheng <staneyffer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csunny csunny csunny approved these changes

@Aries-ckt Aries-ckt Aries-ckt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0sengseng0 @Aries-ckt @csunny @fangyinc