Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update milvus_store.py #1212

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Update milvus_store.py #1212

merged 2 commits into from
Feb 29, 2024

Conversation

darius-gs
Copy link
Contributor

@darius-gs darius-gs commented Feb 29, 2024

Fix the issue where the first character of a collection name must be an underscore or letter: invalid parameter cannot be deleted if the name of the knowledge base is in Chinese after connecting to Milvus v 2.3.7 as a vector database.
#1150 (comment)
Close #1150

Description

Fix the issue where the first character of a collection name must be an underscore or letter: invalid parameter cannot be deleted if the name of the knowledge base is in Chinese after connecting to Milvus v 2.3.7 as a vector database.

How Has This Been Tested?

Chinese Name Knowledge Base Test:

  1. After modifying the code, connect Milvus v 2.3.7 as the vector database and start the project.
  2. Create a Chinese knowledge base on the web interface, and after the prompt is successful, check if the new Collection is successfully created in the Milvus database
  3. Delete the newly created Chinese name knowledge base on the web interface. After a prompt indicating successful deletion, the knowledge base on the web interface disappears, the service log shows no errors, and the corresponding Collection in the Milvus database is successfully deleted
    English Name Knowledge Base Test:
  4. After modifying the code, connect Milvus v 2.3.7 as the vector database and start the project.
  5. Create an English knowledge base on the web interface, and after the prompt is successful, check whether the new Collection was successfully created in the Milvus database
  6. Delete the newly created English named knowledge base on the web interface. After a prompt indicating successful deletion, the knowledge base on the web interface disappears, the service log shows no errors, and the corresponding Collection in the Milvus database is successfully deleted

Snapshots:

Include snapshots for easier review.

Checklist:

  • My code follows the style guidelines of this project
  • I have already rebased the commits and make the commit message conform to the project standard.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

修复 连接Milvus_v 2.3.7作为向量数据库后,知识库的名称要是为中文的,就会提示the first character of a collection name must be an underscore or letter: invalid parameter删不掉的问题。eosphoros-ai#1150 (comment)
@csunny
Copy link
Collaborator

csunny commented Feb 29, 2024

Thanks for your PR, the checks failed, you need to execute black . and make fmt to fix this.

Copy link
Collaborator

@csunny csunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

Copy link
Collaborator

@Aries-ckt Aries-ckt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@Aries-ckt Aries-ckt merged commit d6fabe9 into eosphoros-ai:main Feb 29, 2024
4 checks passed
csunny pushed a commit to oushu1zhangxiangxuan1/DB-GPT that referenced this pull request Mar 1, 2024
Hopshine pushed a commit to Hopshine/DB-GPT that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Milvus_v 2.3.7,cannot delete knowledge space which name is chinese
3 participants