Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(web): set default knowledge icon #1244

Merged
merged 7 commits into from
Mar 4, 2024
Merged

style(web): set default knowledge icon #1244

merged 7 commits into from
Mar 4, 2024

Conversation

2976151305
Copy link
Collaborator

Description

show default knowledge icon

How Has This Been Tested?

Snapshots:

image

Checklist:

  • My code follows the style guidelines of this project
  • I have already rebased the commits and make the commit message conform to the project standard.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

@2976151305 2976151305 changed the title Style/knowledge icon style(web): set default knowledge icon Mar 4, 2024
@2976151305 2976151305 requested review from Aralhi and csunny March 4, 2024 02:42
@Aralhi
Copy link
Collaborator

Aralhi commented Mar 4, 2024

  • The image already exists and does not need to be added. public/models/knowledge-default.jpg
  • please build web static assets before submit a PR.

csunny
csunny approved these changes Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@csunny csunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

Aralhi
Aralhi approved these changes Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@Aralhi Aralhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aralhi Aralhi merged commit 7a38edc into main Mar 4, 2024
4 checks passed
csunny pushed a commit that referenced this pull request Mar 7, 2024
@2976151305 @csunny
style(web): set default knowledge icon (#1244)
70a55ed
@csunny csunny deleted the style/knowledge-icon branch September 2, 2024 10:07
Hopshine pushed a commit to Hopshine/DB-GPT that referenced this pull request Sep 10, 2024
@2976151305 @Hopshine
style(web): set default knowledge icon (eosphoros-ai#1244)
d6547e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csunny csunny csunny approved these changes

@Aralhi Aralhi Aralhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@2976151305 @Aralhi @csunny