-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rag): Fix CrossEncoderRanker bug of EmbeddingRetriever #1504
Conversation
@csunny it seems like a code type check error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM~
@ivanzhu109 I checked the styles and everything looks normal. emm~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@csunny emm~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+
…-ai#1504) Co-authored-by: aries_ckt <916701291@qq.com>
When using EmbeddingRetriever with reranking specified as CrossEncoderRanker, a TypeError ('Object of type float32 is not JSON serializable') occurs when attempting to serialize references of the answer.