Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(model): Support qianfan embedding and resolves an issue #1819

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

dusens
Copy link
Contributor

@dusens dusens commented Aug 13, 2024

Description

  • Support qianfan embedding
  • Fix missing proxy_tongyi_proxy_api_key={your-api-key}
  • update qianfan pip whl

How Has This Been Tested?

Test passed

Snapshots:

Include snapshots for easier review.

Checklist:

  • [ √] My code follows the style guidelines of this project
  • [ √] I have already rebased the commits and make the commit message conform to the project standard.
  • [ √] I have performed a self-review of my own code
  • [ √] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ √] Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added enhancement New feature or request model Module: model labels Aug 13, 2024
Copy link
Collaborator

@csunny csunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dusens It took so long to review this PR,we are very sorry about that, beacuse we have been busy with the v0.6.0 version recently. It is a very helpful PR. Thank you for your contribution. If you are interested in our community, welcome to join our community group.

LGTM

@dusens
Copy link
Contributor Author

dusens commented Aug 29, 2024

Thank you for the feedback and the invitation! I am very interested in joining the community, but I'm not sure how to do so. Could you please provide me with the details on how to join the community group?

@csunny
Copy link
Collaborator

csunny commented Aug 29, 2024

@dusens Please send email to me. cfqcsunny@gmail.com

Copy link
Collaborator

@fangyinc fangyinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fangyinc fangyinc merged commit 51b4327 into eosphoros-ai:main Aug 29, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request model Module: model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants