feat: upload metadata 、ui size settings 276 320 530 、import flow #1956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dreammy23
reviewed
Sep 4, 2024
web/components/flow/canvas-node.tsx
Outdated
| { | ||
| 'w-80':node.tags.ui_size === 'middle' || !node.tags.ui_size, | ||
| 'w-256':node.tags.ui_size === 'small', | ||
| 'w-530':node.tags.ui_size === 'large', |
There was a problem hiding this comment.
这里取数据都改成?.吧，防止空数据
如：node?.tags?.ui_size
Dreammy23
reviewed
Sep 4, 2024
| } | ||
| setFileList(urlList) | ||
| }).catch((res)=>{ | ||
| debugger |
There was a problem hiding this comment.
这里怎么还留一个debugger？一般是message.error 或 console.log(error)
Dreammy23
reviewed
Sep 4, 2024
| @@ -74,13 +105,13 @@ export const renderUpload = (params: Props) => { | |||
| return ( | |||
| <div className='p-2 text-sm text-center'> | |||
| {data.is_list ? ( | |||
There was a problem hiding this comment.
看起来 data.is_list 所在三元表达式区别，只有multiple={true} 和 multiple={false}，可以把三元判断放在这里multiple={data.is_list?true:false}
Dreammy23
reviewed
Sep 4, 2024
| @@ -28,8 +28,9 @@ import 'reactflow/dist/style.css'; | |||
|
|
|||
| const nodeTypes = { customNode: CanvasNode }; | |||
| const edgeTypes = { buttonedge: ButtonEdge }; | |||
| let importData :any= null | |||
There was a problem hiding this comment.
这个importData变量可以写到 Canvas 组件里面，类型最好补充一下，不要使用any
Dreammy23
reviewed
Sep 4, 2024
| @@ -28,8 +28,9 @@ import 'reactflow/dist/style.css'; | |||
|
|
|||
| const nodeTypes = { customNode: CanvasNode }; | |||
| const edgeTypes = { buttonedge: ButtonEdge }; | |||
| let importData :any= null | |||
| const Canvas: React.FC = (props:any) => { | |||
Dreammy23
reviewed
Sep 4, 2024
| export default function CanvasWrapper(data:any) { | ||
|
|
||
| importData = data | ||
| console.log(importData); |
Dreammy23
reviewed
Sep 4, 2024
| width: 530px; | ||
| } | ||
| .w-256{ | ||
| width:256px; |
There was a problem hiding this comment.
不用补充这个哈，使用w-[530px]和w-[256px]
方括号里可以随便自定义公式，可以全局搜一下类似用法
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Snapshots:
Include snapshots for easier review.
Checklist: