Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add postgresql support #626

Merged
merged 7 commits into from
Sep 28, 2023
Merged

feat: add postgresql support #626

merged 7 commits into from
Sep 28, 2023

Conversation

lozzo
Copy link
Contributor

@lozzo lozzo commented Sep 25, 2023

  • add postgresql support
  • dashboard chat prompt update

@github-actions github-actions bot added the enhancement New feature or request label Sep 25, 2023
fangyinc
fangyinc reviewed Sep 25, 2023
View reviewed changes
setup.py Outdated Show resolved Hide resolved
yihong0618
yihong0618 approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@yihong0618 yihong0618 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

pilot/connections/rdbms/conn_postgresql.py Show resolved Hide resolved
pilot/connections/rdbms/conn_postgresql.py Outdated Show resolved Hide resolved
@fangyinc
Copy link
Collaborator

@lozzo Thank you for your patience. Please address the code formatting issues. You can install black with pip install black, and then run black . in the project directory to format the Python code.

@lozzo
Copy link
Contributor Author

lozzo commented Sep 25, 2023

@lozzo Thank you for your patience. Please address the code formatting issues. You can install black with pip install black, and then run black . in the project directory to format the Python code.

done

Aries-ckt
Aries-ckt previously approved these changes Sep 28, 2023
View reviewed changes
fangyinc
fangyinc approved these changes Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@fangyinc fangyinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+.
Thanks for your PR.

@fangyinc fangyinc merged commit a2108e5 into eosphoros-ai:main Sep 28, 2023
3 checks passed
@fangyinc fangyinc mentioned this pull request Sep 28, 2023
Merged
Aries-ckt added a commit that referenced this pull request Sep 28, 2023
@Aries-ckt
chore: Roll back json parsing code (#637)
48aa8b8 
See
[here](#626 (comment))
@csunny csunny mentioned this pull request Nov 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fangyinc fangyinc fangyinc approved these changes

@yihong0618 yihong0618 yihong0618 approved these changes

@Aries-ckt Aries-ckt Aries-ckt left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lozzo @fangyinc @Aries-ckt @yihong0618