Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ChatExcel): Fix ERROR!LLM Response Can't Parser! bug in chat excel scene #688

Closed
wants to merge 1 commit into from
Closed

fix(ChatExcel): Fix ERROR!LLM Response Can't Parser! bug in chat excel scene #688

wants to merge 1 commit into from

Conversation

AlphaHinex
Copy link
Contributor

  1. Expand chat excel retention rounds to 2 to include ChatExcel prompt
  2. Fix typo in base_chat.py: histroy => history

@github-actions github-actions bot added ChatExcel Module: ChatExcel fix Bug fixes labels Oct 18, 2023
@AlphaHinex
Copy link
Contributor Author

chat_retention_rounds had reduced from 2 to 1 in a06e9b2#diff-8022e7bccdb7d45b3dc081d2016a786677b2d3af65415bb482c7e4548199e8b1R29 , but we must upload excel file first (with ExcelLearning prompt) through UI in ChatExcel scene.

If chat_retention_rounds=1, we always load the ExcelLearning conversation in history messages (after load system prompt in generate_llm_messages) and get ExcelLearning json format response, then parse with ChatExcelOutputParser, so we get ERROR!LLM Response Can't Parser! in web view.

@yhjun1026 yhjun1026 closed this Oct 19, 2023
@AlphaHinex
Copy link
Contributor Author

@yhjun1026 ?

@csunny
Copy link
Collaborator

csunny commented Oct 31, 2023

@yhjun1026 this typo error has been fixed?

@csunny csunny reopened this Oct 31, 2023
@yhjun1026
Copy link
Collaborator

this typo error has been fixed?

I haven’t encountered this kind of error report for the time being.

@csunny
Copy link
Collaborator

csunny commented Oct 31, 2023

@yhjun1026

Fix typo in base_chat.py: histroy => history
histroy -> history?

@AlphaHinex AlphaHinex force-pushed the chat-excel-retention-rounds branch from ae67ad6 to bfb288b Compare November 6, 2023 06:36
@AlphaHinex
Copy link
Contributor Author

Extract typo issue to #780

@AlphaHinex AlphaHinex closed this Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ChatExcel Module: ChatExcel fix Bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlphaHinex @csunny @yhjun1026