Update Readme to fix grammar, add new requirements to requirements-de… #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eoyilmaz
approved these changes
Oct 22, 2024
requirements-dev.txt
Outdated
| @@ -20,3 +20,5 @@ pytest-xdist | |||
| snowballstemmer | |||
| twine | |||
| wheel | |||
| Send2Trash | |||
There was a problem hiding this comment.
This is already listed in requirements.txt
requirements-dev.txt
Outdated
| @@ -20,3 +20,5 @@ pytest-xdist | |||
| snowballstemmer | |||
| twine | |||
| wheel | |||
| Send2Trash | |||
| DisplayCAL | |||
There was a problem hiding this comment.
We shouldn't list DisplayCAL here as pip will try to install DisplayCAL through PyPI, which shouldn't be done...
eoyilmaz
added a commit
that referenced
this pull request
Oct 25, 2024
Adam-Color
pushed a commit
to Adam-Color/displaycal-py3
that referenced
this pull request
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…v.txt
Unsure if the requirements need to be updated across all 3 text files, for now I've only done the dev version.