Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor rules/named-export to use context.getDeclaredVariables() #196

Merged
merged 6 commits into from
Nov 22, 2020

Conversation

epaew
Copy link
Owner

@epaew epaew commented Nov 21, 2020

Related issue numbers

after: #195

About the pull request

  • Update rules/named-export to use context.getDeclaredVariables() to parse node tree.
  • Remove unused utils/estree-parser.

Additional context

Add any other context for this pull request here.

@epaew epaew force-pushed the feature/refactor_estree-parser branch 5 times, most recently from 7a49580 to cdbd1e7 Compare November 22, 2020 01:01
@epaew epaew changed the title Remove utils/estree-parser Refactor rules/named-export to use context.getDeclaredVariables() Nov 22, 2020
@epaew epaew force-pushed the feature/refactor_estree-parser branch from cdbd1e7 to 1048ab7 Compare November 22, 2020 01:21
@epaew epaew force-pushed the feature/refactor_estree-parser branch from 1048ab7 to 4b2aeaf Compare November 22, 2020 01:45
@epaew epaew marked this pull request as ready for review November 22, 2020 01:45
@codeclimate
Copy link

codeclimate bot commented Nov 22, 2020

Code Climate has analyzed commit 4b2aeaf and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (60% is the threshold).

This pull request will bring the total coverage in the repository to 94.4% (3.1% change).

View more on Code Climate.

@epaew epaew merged commit 3278dab into master Nov 22, 2020
@epaew epaew deleted the feature/refactor_estree-parser branch November 22, 2020 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant