Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve run billing estimation #3201

Open
mzueva opened this issue Apr 12, 2023 · 0 comments
Open

Improve run billing estimation #3201

mzueva opened this issue Apr 12, 2023 · 0 comments
Assignees
@rodichenko @tcibinan
Labels
kind/enhancement New feature or request

Comments

@mzueva
Copy link
Collaborator

mzueva commented Apr 12, 2023

Background
At the moment we use startDate field of PipelineRun object as a start of billing period for a run, but for some runs we create new compute instances, which may take some significant time and affect accuracy of cost estimation.

Approach
Run cost estimation shall start after actual start of the cloud instance, let's add a new field instanceStartDate to PipelineRun object. We can set this right after nodeup routine is completed in AutoscaleManager. Billing service, ClusterCostsMonitoringService and any other code for compute cost estimation shall use instanceStartDate as a start for billing.
@mzueva mzueva added the kind/enhancement New feature or request label Apr 12, 2023
@tcibinan tcibinan mentioned this issue Apr 17, 2023
Merged
rodichenko added a commit that referenced this issue Apr 20, 2023
@rodichenko
Improve run billing estimation (#3201) - GUI, consider instance start…
43a72e2 
… date for run price estimation
rodichenko added a commit that referenced this issue Apr 20, 2023
@rodichenko
Improve run billing estimation (#3201) - GUI, consider instance start…
ba9b0cf 
… date for run price estimation, backported to stage/0.16/uat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rodichenko rodichenko

@tcibinan tcibinan

Labels
kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rodichenko @mzueva @tcibinan