Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce new amino-acid colours #5187

Closed
ljubica-milovic opened this issue Jul 29, 2024 · 2 comments · Fixed by #5692
Closed

Introduce new amino-acid colours #5187

ljubica-milovic opened this issue Jul 29, 2024 · 2 comments · Fixed by #5692
Assignees
Labels
Test Cases Written Test cases has been written for that issue

Comments

@ljubica-milovic
Copy link
Collaborator

ljubica-milovic commented Jul 29, 2024

Background

The logic of the current colour scheme for amino acids is not as good as it can be. The colours should be changed, for them to be more intuitive and useful to the user.

The chosen logic for amino acid colouring is the colours of litmus paper - where acidic solutions colour the paper red, basic ones colour the paper blue and neutral ones colour the paper purple. Green and yellow are chosen to be colours for non-polar amino acids because they will be different enough visualy from red, purple and blue.

Requirements

  1. All polar, acidic amino acids (two AAs: aspartic acid (D) and glutamic acid (E) and all amino acids with the same natural analogue) should be represented by shades of red.
  2. All polar, basic amino acids (four AAs: lysine (K), arginine (R), histidine (H), pyrrolysine (O) and all amino acids with the same natural analogue) should be represented by shades of blue.
  3. All polar, neutral amino acids (seven AAs: serine (S), threonine (T), cysteine (C), tyrosine (Y), asparagine (N), glutamine (Q), selenocysteine (U) and all amino acids with the same natural analogue) should be represented by shades of purple.
  4. All non-polar amino acids (nine AAs: glycine (G), alanine (A), valine (V), leucine (L), isoleucine (I), methionine (M), tryptophan (W), phenylalanine (F), proline (P) and all amino acids with the same natural analogue) should be represented by shades of green and yellow.
  5. Amino acids with the natural analogue X should stay the same colour (grey).

UX
image

@ljubica-milovic ljubica-milovic added this to the Ketcher 2.25.0-rc.1 milestone Jul 29, 2024
@KristinaKasyanovskaya KristinaKasyanovskaya self-assigned this Aug 16, 2024
@AlexeyGirin AlexeyGirin added the Test Cases Written Test cases has been written for that issue label Aug 23, 2024
@AlexeyGirin
Copy link
Collaborator

Test cases are not needed for that issues

@KristinaKasyanovskaya KristinaKasyanovskaya linked a pull request Oct 8, 2024 that will close this issue
9 tasks
rrodionov91 added a commit that referenced this issue Nov 3, 2024
 - also increased waitForSpinnerFinishedWork timeout

---------

Co-authored-by: Roman Rodionov <roman_rodionov@epam.com>
Co-authored-by: Nikita Chistousov <nikita_chistousov@epam.com>
@AlexeyGirin
Copy link
Collaborator

Verified.
image

  • Ketcher Version 2.27.0-rc.1 Build at 2024-11-05; 14:55:18
  • Indigo Toolkit Version 1.26.0-rc.1.0-g904d2d992-wasm32-wasm-clang-19.0.0
  • Chrome Version 130.0.6723.117 (Official Build) (64-bit)
  • Win10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Test Cases Written Test cases has been written for that issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants