#5969 - Load from file having only micro structures on macro canvas causes unnecessary zoom up to 200% and shift molecule to top left angle #6057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…auses unnecessary zoom up to 200% and shift molecule to top left angle
auto-assign
bot
requested review from
AlexeyGirin,
NataliaLoginova and
svvald
svvald
approved these changes
Dec 4, 2024
| @@ -166,6 +166,16 @@ export class DrawingEntitiesManager { | |||
| return this.allEntities.length !== 0; | |||
| } | |||
|
|
|||
| public get hasMonomers() { | |||
| const monomers = [...this.monomers.values()].filter( | |||
There was a problem hiding this comment.
filter method doesn't mutate the original array and creates a new copy, perhaps you can just use this.monomers.values().filter() here?
There was a problem hiding this comment.
this.monomers.values() returns Iterator, so destructuring operator needs to create array from Iterator.
rrodionov91
deleted the
5969-Load_from_file_having_only_micro_structures_on_macro_canvas_causes_unnecessary_zoom_up_to_200%_and_shift_molecule_to_top_left_angle
branch
rrodionov91
added a commit
that referenced
this pull request
Dec 4, 2024
…auses unnecessary zoom up to 200% and shift molecule to top left angle (#6057)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
(Screenshots, videos, or GIFs, if applicable)
Check list
#1234 – issue name