Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(untested) allow flannel interface selection #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jayunit100
Copy link

Im sure an ansible power-user can steal or modify this, but just wanted to put it up here before i forget :) . I'm still learning about flannel internals and not an ansible expert either, so any feedback on this is welcome, or feel to just borrow the idea and reimplement correctly. '

long story short : if using VMs, eth0 is your enemy !

@jayunit100 jayunit100 force-pushed the flannel_eth branch 2 times, most recently from ac147c8 to 82b3582 Compare June 21, 2015 19:40
@jayunit100
Copy link
Author

ALSO, please confirm that eth0 is the right default. maybe there should be some if/else logic in stead which leaves it optionally empty?

@eparis
Copy link
Owner

eparis commented Jun 21, 2015

I feel like this will break more people than it fixes, aka every single setup on real hardware that has no eth0 (since they moved to the crazy location based names, like enp4s11 or enp0s29f7u4u1, which my system has.)

Maybe better to leave flannel_iface unset in the default and do something like https://github.com/eparis/kubernetes-ansible/blob/master/roles/minion/templates/kubelet.j2#L22 in the template?

users.
Updated w/ eric's idea to make it empty by default.
@jayunit100
Copy link
Author

gotcha, done (patch updated)

@eparis
Copy link
Owner

eparis commented Jun 22, 2015

still untested? even on your setup?

@jayunit100
Copy link
Author

haven't testd it. my VMs are all maxed out right now. after i do an experiment i can test it in vagrant.

Maybe i can build a vagrantfile for easy testing, run the test, and just go ahead and commit it w/ this PR ?

After all, a setup this sophisticated needs/deserves a good Vagrantfile for verifying new commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants