Remove extra slash in proto makefile and remove bindings

[buschbapti]

The makefile in protobuf contained an extra / causing errors during the command

mkdir -p $(CPP_BUILD_DIR); protoc --proto_path=$(PROTO_PATH) --cpp_out=$(CPP_BUILD_DIR) $(PROTO_SOURCES)

The folder was actually not created.

Also, it is fair to say that we can actually remove the bindings from Github. The proper way of building them is actually to copy protobuf from the ghcr.io/epfl-lasa/control-libraries/development-dependencies:latest image:

# install google dependencies
COPY --from=ghcr.io/epfl-lasa/control-libraries/development-dependencies:latest /usr/local/include/google /usr/local/include/google
COPY --from=ghcr.io/epfl-lasa/control-libraries/development-dependencies:latest /usr/local/lib/libproto* /usr/local/lib
COPY --from=ghcr.io/epfl-lasa/control-libraries/development-dependencies:latest /usr/local/bin/protoc /usr/local/bin
RUN ldconfig

Personally I prefer to avoid compiled stuff on Github and this solution avoids having to build the lengthy protobuf so that seems a good compromise.

[domire8]

Good for me, do you want to wait for Enricos review? If thats the case, I would appreciate if the run.sh script and the README would be updated as well. I think this is in the scope of this PR.
If you want this fixed fast, I can give you my okay now.

[eeberhard]

Good catch. The compiler protoc stripped the extra slash and handled it fine, but mkdir did not.

Regarding the binding source not being version controlled, I agree. Initially I saw the installation of protoc as a burden since it really does take a while to build, but now that I put it in the base dependencies image it's much easier for a user to generate the necessary code themselves (and in fact the CI regenerate these bindings fresh anyway). I still think if C++ libproto runtime could be installed easily without needing protoc, it would not be bad practice to version control the generated bindings. And, pulling a >2GB image just to generate <<1MB of code has its own disadvantages. But, overall, the clarity of the diff will be better if the bindings are removed 👍

I agree with @domire8 that the run.sh should also be deleted, and the protocol/README needs a few lines changed as a result. Finally, I would ask you to add BUILD_DIR (protocol/protobuf/bindings) to gitignore.

Thanks for the help in streamlining this as you are integrating clproto for downstream use

[domire8]

And, pulling a >2GB image just to generate <<1MB of code has its own disadvantages. But, overall, the clarity of the diff will be better if the bindings are removed +1

I should not answer because you should be on holidays but I think Baptiste's final intention would be to host a lightweight image (FROM alpine and then install protobuf) such that you can simply pull this small image and then copy the google dependencies from there.

[buschbapti]

Alright thank you both for the feedback. Indeed as @domire8 mentioned I think we should host some lightweight images based on alpine distribution to build and distribute such libraries. This will also facilitate the maintenance of versions. We can do that later and for now stick with the development image.

[domire8]

good job cleaner 😄