Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tag generation for release docs #225

Merged
merged 2 commits into from
Nov 15, 2021
Merged

Fix tag generation for release docs #225

merged 2 commits into from
Nov 15, 2021

Conversation

domire8
Copy link
Contributor

@domire8 domire8 commented Nov 14, 2021

The GITHUB_REF for a release event is actually refs/tags/vXXX and not refs-tags/vXXX which is why the doc generation for a new release always failed. This should be fixed now. Tested on my fork of control libraries

@domire8 domire8 force-pushed the fix/docs-generation branch from 4c89102 to e2ac6eb Compare November 14, 2021 14:12
Copy link
Contributor

@buschbapti buschbapti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice very good catch

Copy link
Member

@eeberhard eeberhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah that would explain it! This is something I tried to fix after the last release but didn't get right, and it's because the line {TAG/\//-} was already converting it to refs-tags so I missed what it was actually supposed to be. Thanks!

@domire8 domire8 merged commit 218ad52 into develop Nov 15, 2021
@domire8 domire8 deleted the fix/docs-generation branch November 15, 2021 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants