Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user sshd configuration and user 'developer' in base Dockerfile #244

Merged
merged 4 commits into from
Jan 30, 2022

Conversation

domire8
Copy link
Contributor

@domire8 domire8 commented Jan 26, 2022

PR #243 got a bit out of hand and was not easy to review, so I'm opening this again with nicer commits. I will also do the demo scripts in a next PR, to keep the diff smaller.

So here, review by commit is strongly suggested and will make it easier to understand whats going on. The changes in the two dev-server.sh scripts are strongly inspired by the aica-docker server script.

Copy link
Member

@eeberhard eeberhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to do this and clean it up into a digestible PR. It looks good to me, though I haven't yet had a chance to test it locally. I will try to do that before the end of the week just to make sure the scripts and everything behave as expected also on Mac as Linux.

@domire8
Copy link
Contributor Author

domire8 commented Jan 26, 2022

Thanks for taking the time to do this and clean it up into a digestible PR. It looks good to me, though I haven't yet had a chance to test it locally. I will try to do that before the end of the week just to make sure the scripts and everything behave as expected also on Mac as Linux.

To test, you need to first build the base image and tag as epfl-lasa/control-libraries/development-dependencies, remove ghcr.io/ from line 1 in Dockerfile.python, Dockerfile.source and line 3 in source/dev-server.sh and additionally comment the docker pull ${IMAGE_NAME} in source/dev-server.sh.

@domire8 domire8 force-pushed the feature/docker-improvments branch from 27c5553 to 2f42929 Compare January 28, 2022 19:17
@eeberhard
Copy link
Member

To test, [...]

Thank you, I would have figured it out but that was very helpful to save me a few minutes. Everything works as expected on my side (Mac). Of course I had to change the toolchain and mapping from remote@localhost and /home/remote to developer@localhost and /home/developer in CLion. Good stuff!

@domire8 domire8 merged commit 9befe6f into develop Jan 30, 2022
@domire8 domire8 deleted the feature/docker-improvments branch January 30, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants