Incremental versioning #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Require contributors to update the version number with each PR
* Contain the current project version in a VERSION text file, for internal and possible external convenience
* Add script to make updating the project version across all relevant files easy
domire8
previously approved these changes
Feb 21, 2022
buschbapti
previously approved these changes
Feb 22, 2022
* Handle the difference in `sed` argument parsing between Mac and Linux using if / else case * Remove dependency on `bc` calculator tool and use bash arithmetic expansion expressions instead
|
I decided it would be a nice idea to make sure that this works on linux too, since the |
buschbapti
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a snazzy little script to make incremental versioning of our development patches easier.
I want all little features, fixes and patches in develop to have a respective patch number, so that we can keep track of changes more easily. But, changing the project version in all the right places is a bit cumbersome.
This script makes it really easy to update the version number at the end of a PR. Basically, once your feature is ready to go, you can do
./update_version.sh --commitand it will automatically increment the patch number in all the files and generate a commit for you.See the help text for the other options. At a future point we can get the CI to do this for us, but for now let's try it out manually.
I wouldn't mind this being the first PR after the 5.0.0 release, to set the foundation nicely, after which the other pending PRs can close.