Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker resources for testing and serving for protocol #267

Merged
merged 6 commits into from
Mar 14, 2022

Conversation

domire8
Copy link
Contributor

@domire8 domire8 commented Mar 11, 2022

While we had Dockerfile.source and Dockerfile.python, we never had a Dockerfile.protocol so far where we can test and launch a dev server if we are developing clproto. I'm adding those missing pieces here (inspired by @eeberhard).

@domire8 domire8 requested review from buschbapti and eeberhard March 11, 2022 08:13
@domire8 domire8 force-pushed the feature/protocol-dockerfile branch from de052a4 to b61f4f4 Compare March 14, 2022 09:29
Copy link
Member

@eeberhard eeberhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It was overdue, and I should have pushed my local files at some point but never got around to it. This is very helpful.

@domire8 domire8 merged commit ee7d9fc into develop Mar 14, 2022
@domire8 domire8 deleted the feature/protocol-dockerfile branch March 14, 2022 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants