Add encode/decode option for shared pointer of State #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domire8
force-pushed
the
feature/clproto-state-ptr
branch
from
8cd9769 to
4661e77
Compare
eeberhard
previously approved these changes
Apr 19, 2022
eeberhard
previously approved these changes
Apr 19, 2022
Co-authored-by: Enrico Eberhard <32450951+eeberhard@users.noreply.github.com>
domire8
force-pushed
the
feature/clproto-state-ptr
branch
from
514d571 to
56d9e84
Compare
eeberhard
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I add a feature that is required the modulo component refactor. It's three big switch cases to decode and encode shared pointers of State via pointer injection and dynamic cast.
The number of deletions are quite high because templated the tests quite a lot.
What I'm not sure is if I have to do something in python too or not. I guess not because all variables are already pointers in python?