Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pkg-config to check for dependencies #328

Merged
merged 5 commits into from
Dec 20, 2022
Merged

Conversation

domire8
Copy link
Contributor

@domire8 domire8 commented Dec 16, 2022

A hopefully final PR here to introduce pkg-config everywhere. We can now use the Python module to check for installed dependencies too, instead of the CMake CLI.

Copy link
Member

@eeberhard eeberhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this series of PRs. It's very consistent and sensible like this and nice to see it across cmake and python setup.py

@domire8 domire8 merged commit d305bc3 into develop Dec 20, 2022
@domire8 domire8 deleted the feature/use-pkg-config branch December 20, 2022 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants