discojs-core/dataset/builder: fw config

epfml · Apr 26, 2024 · 8b3d4ec · 8b3d4ec
1 parent c396a8a
commit 8b3d4ec
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/discojs/discojs-core/src/dataset/dataset_builder.ts b/discojs/discojs-core/src/dataset/dataset_builder.ts
@@ -128,7 +128,7 @@ export class DatasetBuilder<Source> {
         shuffle: false
       }
       const sources = this.labelledSources.valueSeq().toArray().flat()
-      dataTuple = await this.dataLoader.loadAll(sources, defaultConfig)
+      dataTuple = await this.dataLoader.loadAll(sources, { ...defaultConfig, ...config })
     }
     // TODO @s314cy: Support .csv labels for image datasets (supervised training or testing)
     this._built = true

diff --git a/web-client/src/components/training/Trainer.vue b/web-client/src/components/training/Trainer.vue
@@ -131,7 +131,10 @@ export default defineComponent({
 
       let dataset: data.DataSplit
       try {
-        dataset = await this.datasetBuilder.build()
+        dataset = await this.datasetBuilder.build({
+          shuffle: true,
+          validationSplit: this.task.trainingInformation.validationSplit
+        })
       } catch (e) {
         console.error(e)
         if (e instanceof Error && e.message.includes('provided in columnConfigs does not match any of the column names')) {