Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fondations for LLM #643

Merged
merged 8 commits into from
Mar 1, 2024
Merged

add fondations for LLM #643

merged 8 commits into from
Mar 1, 2024

Conversation

tharvik
Copy link
Collaborator

@tharvik tharvik commented Feb 29, 2024

merging LLM (from #619) requires some reshaping of the code, here goes some changes splitted from the original PR.

  • add a Model abstracting away tensorflow specifics
    • still incomplete as it input/output tf.Tensors for now, and one can extract the tf.LayersModel
    • remove Task.training.modelCompileData as it's now contained inside the models.TFJS
  • add typesafe event emitter to safely register/call callbacks
  • rename Task.taskID to Task.id
  • while at it: drop unused training_functions, update axios, use async file read

@tharvik tharvik self-assigned this Feb 29, 2024
Base automatically changed from 638-no-reexport-tharvik to develop February 29, 2024 11:52
@tharvik tharvik force-pushed the 641-partial-merge-llm-tharvik branch from dd8a4f6 to cf5545b Compare February 29, 2024 12:06
@tharvik tharvik force-pushed the 641-partial-merge-llm-tharvik branch from cf5545b to bb51e16 Compare March 1, 2024 09:50
@tharvik tharvik force-pushed the 641-partial-merge-llm-tharvik branch from bb51e16 to 10be5f1 Compare March 1, 2024 10:16
@tharvik tharvik marked this pull request as ready for review March 1, 2024 10:26
@tharvik tharvik merged commit 8eede14 into develop Mar 1, 2024
20 checks passed
@tharvik tharvik deleted the 641-partial-merge-llm-tharvik branch March 1, 2024 14:35
@JulienVig
Copy link
Collaborator

JulienVig commented Mar 4, 2024

For what it's worth very good stuff! I only left comments for what I didn't understand but it's a very nice refactoring

@tharvik tharvik mentioned this pull request Mar 5, 2024
@tharvik
Copy link
Collaborator Author

tharvik commented Mar 5, 2024

For what it's worth very good stuff! I only left comments for what I didn't understand but it's a very nice refactoring

héhé, thanks 😄

followup of fixes from your remarks #645

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants