Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Xmtp Engine Rerenders, Race Conditions, Crashes #1036

Open
wants to merge 2 commits into
base: release/2.0.8
Choose a base branch
from

Conversation

alexrisch
Copy link
Collaborator

Refactored Xmtp Engine to be outside of React Context
Refactored Xmtp Cron to be outside of React Context
Adds subscriptions
Moves app state into folder and adds new app state utils

Refactored Xmtp Engine to be mostly outside of React Context
Adds subscriptions
Moves app state into folder and adds new app state util
@alexrisch alexrisch requested a review from a team as a code owner October 19, 2024 12:58
Copy link
Contributor

Performance Comparison Report

  • Current: 98cd135 - 2024-10-19 13:01:59Z
  • Baseline: release/2.0.8 (28159be) - 2024-10-19 13:01:19Z

Significant Changes To Duration

There are no entries

Meaningless Changes To Duration

Show entries
Name Type Duration Count
Avatar Image 10 runs render 1.1 ms → 1.2 ms (+0.1 ms, +9.1%) 1 → 1
Avatar Image 50 runs render 1.2 ms → 1.1 ms (-0.1 ms, -6.9%) 1 → 1
Empty Avatar 10 runs render 1.3 ms → 1.0 ms (-0.3 ms, -23.1%) 🟢 1 → 1
Empty Avatar 50 runs render 0.8 ms → 0.7 ms (-0.0 ms, -5.1%) 1 → 1
Show details
Name Type Duration Count
Avatar Image 10 runs render Baseline
Mean: 1.1 ms
Stdev: 0.3 ms (28.7%)
Runs: 2 1 1 1 1 1 1 1 1 1
Warmup runs: 3

Current
Mean: 1.2 ms
Stdev: 0.4 ms (35.1%)
Runs: 2 1 1 1 1 1 1 2 1 1
Warmup runs: 3
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Render issues:

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Render issues:
Avatar Image 50 runs render Baseline
Mean: 1.2 ms
Stdev: 0.4 ms (36.4%)
Runs: 1 1 1 2 1 1 2 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 0 2 2 1 1 1 2 1 1 2 1 2 2 1 1 1 1 1 1 2 1 1 1 1 1 1 1
Warmup runs: 2

Current
Mean: 1.1 ms
Stdev: 0.3 ms (25.4%)
Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 2 1 1 1 1 1 1 1 1 1 1 1 1 2 1 1 1 1 2 1 2 1 1 1 1 1 1 1 1
Warmup runs: 1
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1
Render issues:

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1
Render issues:
Empty Avatar 10 runs render Baseline
Mean: 1.3 ms
Stdev: 0.5 ms (37.2%)
Runs: 1 2 2 2 1 1 1 1 1 1
Warmup runs: 74

Current
Mean: 1.0 ms
Stdev: 0.5 ms (47.1%)
Runs: 0 2 1 1 1 1 1 1 1 1
Warmup runs: 9
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Render issues:

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Render issues:
Empty Avatar 50 runs render Baseline
Mean: 0.8 ms
Stdev: 0.5 ms (59.6%)
Runs: 1 1 0 0 1 1 1 0 1 1 1 2 1 1 0 1 1 1 0 1 1 1 1 1 1 1 1 1 1 1 1 1 0 0 1 1 1 0 1 1 1 1 0 1 0 0 1 0 1 1
Warmup runs: 1

Current
Mean: 0.7 ms
Stdev: 0.4 ms (59.9%)
Runs: 1 1 0 1 1 1 1 0 1 1 1 1 0 0 0 0 1 1 1 1 1 1 1 0 0 1 0 0 1 1 1 1 1 0 0 1 1 1 1 1 1 1 1 1 1 1 0 1 1 1
Warmup runs: 1
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1
Render issues:

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1
Render issues:

Render Count Changes

There are no entries

Render Issues

There are no entries

Added Scenarios

There are no entries

Removed Scenarios

There are no entries

Generated by 🚫 dangerJS against 5ec6299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant